Update mypy and make AbstractSaveable.save return Self type
#1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mr-Geekman
commented
May 5, 2023
| @@ -163,7 +166,7 @@ def get_etna_version() -> Tuple[int, int, int]: | |||
| return result | |||
|
|
|||
|
|
|||
| class SaveMixin: | |||
| class SaveMixin(AbstractSaveable): | |||
There was a problem hiding this comment.
It won't work without this somehow.
|
🚀 Deployed on https://deploy-preview-1261--etna-docs.netlify.app |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #1261 +/- ##
=======================================
Coverage 87.98% 87.98%
=======================================
Files 186 186
Lines 10751 10754 +3
=======================================
+ Hits 9459 9462 +3
Misses 1292 1292
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@GrozniyToaster plz help |
|
It looks like it won't work without inheritance. Mypy is bad at checking abstract class signatures, you can try with Protocols |
added 4 commits
May 23, 2023 10:19
This reverts commit 2c5a491.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting (must do checklist)
Proposed Changes
Closing issues